✨ Adds p4a --numeric-version support #1126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll add the unit tests in another dedicated PR after addressing #1119 (comment) |
AndreMiras
force-pushed
the
feature/expose_p4a_numeric_version_param
branch
from
55f27f4
to
a25f7cb
Compare
inclement
previously approved these changes
May 27, 2020
inclement
reviewed
May 27, 2020
AndreMiras
force-pushed
the
feature/expose_p4a_numeric_version_param
branch
2 times, most recently
from
5578646
to
cb05998
Compare
This flag is available in p4a and can be useful to have buildozer side too. Also refs kivy#1079
AndreMiras
force-pushed
the
feature/expose_p4a_numeric_version_param
branch
from
cb05998
to
a815afc
Compare
inclement
approved these changes
May 27, 2020
AndreMiras
added a commit
to AndreMiras/PyWallet
that referenced
this pull request
May 28, 2020
This is needed due to some of the recent changes in p4a and the way the version was automatically computed. New way of computing the versionCode is now giving a lower code which isn't possible to upload on the Play store. Refs: kivy/buildozer#1126
AndreMiras
added a commit
to AndreMiras/buildozer
that referenced
this pull request
May 29, 2020
Follow-up for kivy#1126
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This flag is available in p4a and can be useful to have buildozer side too.
Also refs #1079