-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✅ Also integration test on macOS #1131
✅ Also integration test on macOS #1131
Conversation
if: matrix.os == 'macOS-latest' | ||
run: | | ||
brew install automake | ||
sudo ln -sfn /usr/local/opt/openssl /usr/local/ssl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a workaround that could easily be integrated p4a side by patching Python to add /usr/local/opt/openssl
to the search path.
I actually think it should be a CPython upstream fix, I may look into this in the future
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's interesting indeed. Did macOS move this recently? Anyway, seems like a good fix for CI purposes.
Is this something users are going to have problems with?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assumed user may have problem with it, even though I didn't directly see the problem yet on my macOS.
What I saw is without this fix the python3 config.log
clearly show it didn't find the openssl lib. However later I didn't get the pip SSL error. However on the CI I do get the error 🤔
So yes I may pull request this CPython upstream because the fix is easy
@@ -60,8 +65,17 @@ jobs: | |||
- run: buildozer init | |||
- name: SDK, NDK and p4a download | |||
run: | | |||
sed "s/# android.accept_sdk_license = False/android.accept_sdk_license = True/" -i buildozer.spec | |||
sed -i.bak "s/# android.accept_sdk_license = False/android.accept_sdk_license = True/" buildozer.spec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sed in macOS doesn't work the same way as the one in Linux, the -i.bak
is doing the trick to work on both
28f445f
to
d8f09bf
Compare
Note the `sed` expression got updated to work for both OS. Also workaround openssl lib install on macOS, the error was: ``` RAN: /bin/bash -c 'venv/bin/pip install Cython' STDOUT: WARNING: pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available. Collecting Cython WARNING: Retrying (Retry(total=4, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/cython/ WARNING: Retrying (Retry(total=3, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/cython/ WARNING: Retrying (Retry(total=2, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/cython/ WARNING: Retrying (Retry(total=1, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/cython/ WARNING: Retrying (Retry(total=0, connect=None, read=None, redirect=None, status=None)) after connection broken by 'SSLError("Can't connect to HTTPS URL because the SSL module is not available.")': /simple/cython/ Could not fetch URL https://pypi.org/simple/cython/: There was a problem confirming the ssl certificate: HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /simple/cython/ (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.")) - skipping ERROR: Could not find a version that satisfies the requirement Cython (from versions: none) ERROR: No matching distribution found for Cython WARNING: pip is configured with locations that require TLS/SSL, however the ssl module in Python is not available. Could not fetch URL https://pypi.org/simple/pip/: There was a problem confirming the ssl certificate: HTTPSConnectionPool(host='pypi.org', port=443): Max retries exceeded with url: /simple/pip/ (Caused by SSLError("Can't connect to HTTPS URL because the SSL module is not available.")) - skipping ```
d8f09bf
to
32c5b83
Compare
Note the
sed
expression got updated to work for both OS.Also workaround openssl lib install on macOS, the error was: