🔥 Drops garden support #1142
Merged
🔥 Drops garden support #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I kept it simple and only ditched the feature without further notice. We saw too many users being confused recently with the way to install/use gardens. Furthermore most used gardens are already migrated to the new structure |
opacam
previously approved these changes
Jun 11, 2020
buildozer/__init__.py
Outdated
Comment on lines
511
to
516
| def check_garden_requirements(self): | ||
| '''Ensure required garden packages are available to be included. | ||
| ''' | ||
| garden_requirements = self.config.getlist('app', | ||
| 'garden_requirements', '') | ||
|
|
There was a problem hiding this comment.
Maybe we should emit some kind of removed warning (or maybe raise an exception) in case that we found garden_requirements inside a buildozer.spec file. This way, users could move the garden requirements...otherwise all garden packages will be silently omitted, am I right?
There was a problem hiding this comment.
Addressed (but untested)
Garden are now installed like normal packages, refs: https://kivy.org/doc/stable/api-kivy.garden.html#update-to-garden-structure
AndreMiras
force-pushed
the
feature/garden_is_deprecated
branch
from
32b37ea to
e8b20d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Garden are now installed like normal packages, refs:
https://kivy.org/doc/stable/api-kivy.garden.html#update-to-garden-structure