Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add android.adb_args option #1238

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

germn
Copy link
Contributor

@germn germn commented Oct 15, 2020

Now, if a buildozer is in a Docker container, to make it work with a Linux host you have to pass several unobvious flags to the Docker. I wasn't able to make it work with Windows host at all.

However, it's possible to achieve the same much easier, if we could pass a flag to the adb command. It makes buildozer in a Docker work without any additional Docker flags and on any host (AFAIK).

The PR adds a possibility to pass an argument(s) to the adb. Uncomment the default value (-H host.docker.internal) and run buildozer android deploy from inside Docker to see the effect.

@broccoliboy
Copy link

I would love to see this PR merged. I was just struggling with the problem of deploying to an android device from inside a VS Code devcontainer based on the official kivy/buildozer container. With this PR I can configure buildozer in the devcontainer to use the host's adb server which has already been configured with my devices. This enables seamless build, deploy, and logcat viewing from within the devcontainer.

@adin234
Copy link

adin234 commented Jan 6, 2021

any updates on this one?

@germn
Copy link
Contributor Author

germn commented Jan 6, 2021

any updates on this one?

Let's try to ping few people who can merge: @inclement @AndreMiras @tito

Note, however, that instead of waiting you can create your fork of buildozer, merge the PR and use it now.
Or you can, for example, install buildozer from the PR's branch:
pip install https://github.com/germn/buildozer/archive/add_adb_args_option.zip

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for the proposal

@AndreMiras AndreMiras merged commit 54b2975 into kivy:master Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants