Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use HTTPS urls #1319

Merged
merged 1 commit into from
Apr 24, 2021
Merged

use HTTPS urls #1319

merged 1 commit into from
Apr 24, 2021

Conversation

obfusk
Copy link
Contributor

@obfusk obfusk commented Apr 22, 2021

No description provided.

@obfusk
Copy link
Contributor Author

obfusk commented Apr 24, 2021

@AndreMiras @tshirtman

Most of those URLs -- e.g. in the README -- aren't very important.

But downloading e.g. ant and kivy over unencrypted http w/o checking e.g. a SHA256 checksum is pretty bad security practice nowadays.

Copy link
Member

@tshirtman tshirtman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test the updated instructions, but indeed it's important to switch to https as much as possible.

@obfusk
Copy link
Contributor Author

obfusk commented Apr 24, 2021

I tested the HTTPS URLs to see if they work, though I did not check whether the result is identical.

This is why I added a www. prefix to the sphinx URLS, since the URL without the prefix doesn't work over HTTPS.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndreMiras AndreMiras merged commit ead2d9f into kivy:master Apr 24, 2021
@obfusk
Copy link
Contributor Author

obfusk commented Apr 25, 2021

Given the security implications and otherwise harmlessness of these changes may I suggest doing a point release that includes (only) these changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants