-
Notifications
You must be signed in to change notification settings - Fork 506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aab (Android App Bundle) support #1356
Conversation
Hi, I confirm that this branch works both for independent APK and AAB, and the bundle was accepted by Google Store. Well done Mirko, Congratulations! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test, but looks good to me, and as others confirm it works :)
Tested this and it appears A debug or release build of an existing buildozer.spec will default to android.archs = arm64-v8a, armeabi-v7a, which will produce a multi architecture apk. In the debug case (which is most builds) this will be an issue. For backwards compatibility, I suggest removing |
6fd83f2
to
98a9b27
Compare
98a9b27
to
88aa7e8
Compare
@RobertFlatt , I think we reached both my target and yours with the latest changes. Can you take a look? |
88aa7e8
to
4f34f31
Compare
@misl6 misl6
Works for me. 😀 This is my understanding of the current behavior https://github.com/Android-for-Python/Android-for-Python-Users#release-builds perhaps you could sanity check? Unrelated to Buildozer, building Pillow with the develop p4a, now seems like the gating issue. For me kivy/python-for-android#2497 (comment) addresses the issue. Though I don't understand enough to know if there are side effects. I also tried some new (for me) tests - just more confirmation of all good: Run times with p4a develop are about the same as p4a master, and using p4a develop a two architecture build adds very roughly 60% run time to a one architecture build. I also built a debug apk including androidx and Java source, which installed and ran. Much to my surprise adb successfully installed a two architecture debug apk (picking one). |
Hi, Since latest p4a broke android.arch numeric_version (different arch compilation ends up with the same numeric version) But deploy function doesn't work anymore, as it is not possible to install an .aab file with adb install. My current method was to install bundletool on the system and i did manually:
If by default this PR build aab, deploy command should be updated at the same time |
It got mentionned on discord that there is a configuration token to configure the output: either APK or AAB. More than AAB, since buildozer is made for helping user, we could generate AAB + APK by default (especially in release mode). As APK is required for testing prior publication, and AAB for publishing. |
@tito : Building both Considering that on Google Play Console there's a chance to set up an internal test (fast path) or external test (requires a validation) that could be used to test the I'm thinking about something configurable as it follows: The main reason is the lack of time to implement these changes at this time, cause I'm prioritizing the Apple Silicon support 🔨 , but there's also a high demand for AAB support on buildozer mainstream. |
Hi, I have a question. If I changed locally p4a aab related changes in .buildozer (as I have a lot of my own changes there, no time to update to latest) and also buildozer.spec, and relevant buildozer aab related changes. But I still have apk created, not aab. Is it mandatory to invoke buildozer clean and buildozer init (I don't want to make p4a replaced in .buildozer)? |
4f34f31
to
f83d6fd
Compare
Any reason not to merge this? Seems pretty much mandatory at this point :) |
Considering that checks if the |
This PR adds aab (Android App Bundle) support to
buildozer
.Shouldn't be merged until kivy/python-for-android#2467 is ready and merged into the p4a
develop
branch.TODO:
Force CI to build against(Not needed, aab-support branch for python-for-android has been merged in develop)aab-support
branch ofpython-for-android
buildozer android release
step)arch
toarchs
(in buildozer.spec + warnings during run)android.release_artifact
usage (in buildozer.spec)buildozer.spec
usesarch
instead ofarchs
python-for-android
pinned version doesn't have AAB support.