Refactor checkbin to use shutil.which #1628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
checkbin used custom code to find where a binary is on the path. shutil.which is a built-in to do the same thing since Python 3.3. Simpler and works across platforms.
|
Failed tests are for Python 2, that is no longer supported. |
Yeah, these checks are only here to make sure we do not remove the "Unsupported Python version" statement. I guess we can remove this check, as there's no need to over-complicate things here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
checkbin used custom code to find where a binary is on the path.
shutil.which is a built-in to do the same thing since Python 3.3.
Simpler and works across platforms.