Factor out logging code from Buildozer class #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Julian-O
changed the title
Julian-O
commented
Jul 8, 2023
buildozer/targets/osx.py
Outdated
| @@ -20,14 +22,14 @@ def ensure_sdk(self): | |||
| join(self.buildozer.platform_dir, 'kivy-sdk-packager-master')): | |||
| self.buildozer.info( | |||
There was a problem hiding this comment.
Missed a few self.buildozer.infos.
Result of self review
misl6
requested changes
Jul 17, 2023
There was a problem hiding this comment.
Seems we still have two old references:
buildozer/buildozer/scripts/client.py
Line 19 in 0851a10
buildozer/buildozer/scripts/remote.py
Line 274 in 0851a10
Unfortunately I missed them from the previous review.
(That part will likely need a huge cleanup, but makes sense to keep it updated ATM)
|
These sneaky ones created a Buildozer() object just to call logging! I missed them in my text searches. That left me red-faced. I should have caught these, sorry. |
misl6
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First step toward #1629.
Code related to logging moved into its own class/file.
References (including in targets and tests) updated.
Unit tests separated out, and enhanced to test more conditions.
Trivial indenting/grammar issues in osx.py fixed.
No-op exception handling code removed.