Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests of the documentation. #1683

Merged
merged 1 commit into from
Sep 9, 2023
Merged

Add tests of the documentation. #1683

merged 1 commit into from
Sep 9, 2023

Conversation

Julian-O
Copy link
Contributor

@Julian-O Julian-O commented Sep 8, 2023

The RST files in a pull request might be malformed. URLs might be broken. These should be included in the unit-tests so they are immediately noticed.

This runs a Sphinx build on the documentation (and throws away the result). It also runs a URL check.

Note: The existing documents have some warnings - look for a separate PR to address those.

I did experiment, and confirm that an error like a bad URL causes this test to fail.

Tests external links lead to real destinations and that the entire documents can be generated.
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea! We should add the same elsewhere!

LGTM. Thank you!

@misl6 misl6 merged commit 6e3fcb0 into kivy:master Sep 9, 2023
13 of 15 checks passed
@Julian-O Julian-O deleted the testthedocs branch September 10, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants