-
Notifications
You must be signed in to change notification settings - Fork 507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed auto build type (ant or gradle) detection #597
Conversation
…radle is not reliable method)
…xample NDK v. 16, not 16b
Thanks, looks good. I'll try to test and merge at the weekend. If anyone else would like to test it and confirm it works, that would be welcome. |
I can't merge this PR as it contains other changes than the one PR targetted. master got a fix about it |
hi
sorry but your method of build type detection is still not reliable.
file build.gradle may exist even for non graddle builds. for example if p4a
recipe has own build.gradle like sdl2 recipe has. then you will get copy
error tryint to copy apk with graddle name pattern instead and named apk
2017-12-15 16:57 GMT+02:00 Mathieu Virbel <notifications@github.com>:
… Closed #597 <#597>.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#597 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABw9Ns9J7v5_SVoFSmB871Bvh1INUm4Gks5tAojcgaJpZM4Q2TWY>
.
|
hi |
Hi @ibobalo I can tell that after updating to buildozer==0.34 I still get the issue, can you provide another pull request built on top of 0.34 with the reliable method you describe, so I can tell you. |
hi
sorry, its old story. i'm not in kivy/buildozer/python context now and have
no spare time to remember.
ср, 4 лип. 2018 о 16:13 Andre Miras <notifications@github.com> пише:
… Ping @ibobalo <https://github.com/ibobalo> there's a pull request that
may fix it #691 <#691> could you
review it please?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#597 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABw9Nqmwy1wBneCSqD0pqMRnRb3TsJnnks5uDL-PgaJpZM4Q2TWY>
.
|
fixed auto build type (ant or gradle) apk detection. existence of build.gradle is not reliable method, it may be created by some recipes and is not used by python for android.