Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NO_CONFIG and NO_FILE_LOG #670

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Remove NO_CONFIG and NO_FILE_LOG #670

merged 1 commit into from
Jan 24, 2022

Conversation

akshayaurora
Copy link
Member

@akshayaurora akshayaurora commented Jan 24, 2022 •
edited
Loading

Both were necessary once cause they lead to issues with console. Not so anymore.

@akshayaurora
Remove NO_CONFIG and NO_FILE_LOG
8782e28 
Both were necessary once cause they lead to issue. Not so anymore
AndreMiras
AndreMiras approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the context

misl6
misl6 approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@misl6 misl6 merged commit ab219f0 into master Jan 24, 2022
@akshayaurora akshayaurora deleted the CONSOLE_LOG_n_FILE_LOG branch January 24, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

@AndreMiras AndreMiras AndreMiras approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akshayaurora @AndreMiras @misl6