Fix download from sourceforge (and possibly many others)
#830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AndreMiras let's see what the CI thinks about it, but that's what I was talking about in #827 (comment). Do you recall why we faked the User Agent previously? |
AndreMiras
approved these changes
Jul 16, 2023
There was a problem hiding this comment.
I don't recall why we used it for kivy-ios, it was introduced pretty early it seems, see 577dea0
For p4a I recall something, where some recipes downloads where returning some 403 or something as if the original python requests user agent was blocked, maybe that issue for instance kivy/python-for-android#2418
But let's give it a try with this PR and if it breaks other recipes, we could get different types of user agents for the recipes that break
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sourceforge (and possibly many others) website is showing an intermediate waiting page when the user agent can handle it.
Instead, by using
Wget/1.0as user agent, the redirect to the appropriate mirror works fine.This code is taken from
python-for-android, which had a similar issue withliblzma.... 💬 would be nice to have a utils library to share against
python-for-androidandkivy-iosin order to avoid duplicate effort.Additionally:
FancyURLopenerhas been deprecated in3.3, and I guess it will be removed soon?