Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

matplotlib recipe #858

Merged
merged 11 commits into from
Sep 10, 2023
Merged

matplotlib recipe #858

merged 11 commits into from
Sep 10, 2023

Conversation

tcaduser
Copy link
Contributor

@tcaduser tcaduser commented Sep 9, 2023

Resolves issue #712 and issue #857

Successfully builds matplotlib and its dependency kiwisolver. Leverages existing recipes for numpy, freetype, etc.

Takes care of all known duplicate symbol issues. Meets pep8 requirements.

To build:

python3 -mvenv venv
source venv/bin/activate
cd kivy-ios
pip install -e .
toolchain build matplotlib

screenshot when integrated with my application:

IMG_3256

@tcaduser
Copy link
Contributor Author

tcaduser commented Sep 9, 2023

FWIW, that screenshot is from my iphone, and not a simulator.

kivy_ios/tools/cpplink Outdated Show resolved Hide resolved
Copy link
Contributor Author

@tcaduser tcaduser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff, thanks for the PR and for addressing some of the comments and CI issues already.
Great progress overall.
CI is failing with:

2023-09-09T19:46:09.5904620Z [DEBUG   ] error: command '/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/tools/cpplink' failed: No such file or directory

refs https://github.com/kivy/kivy-ios/actions/runs/6131086632/job/16643997732?pr=858
If I had to guess I would say cpplink should be added to the MANIFEST.in.

I've also gave some ideas to help with cpplink readability, let me know what you think

kivy_ios/tools/cpplink Outdated Show resolved Hide resolved
AndreMiras
AndreMiras previously approved these changes Sep 9, 2023
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing.
Will merge after the build_updated_recipes build turns green

@tcaduser
Copy link
Contributor Author

tcaduser commented Sep 9, 2023

Looks like I needed to include some template files in the Manifest. These were brought over from p4a.

@AndreMiras
Copy link
Member

Great that you saw it too, thanks for addressing already.
Here's the error for records.

2023-09-09T22:05:49.5544410Z FileNotFoundError: [Errno 2] No such file or directory: '/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/kivy_ios-2023.8.24-py3.11.egg/kivy_ios/recipes/matplotlib/setup.cfg.template'

I'll be away from keyboard until tomorrow UTC to review/merge.
Good luck for the build 🤞

@tcaduser
Copy link
Contributor Author

I think I found the last issue in getting the right include file for numpy.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI happy well done 👏
Thanks for the quick follow up

@AndreMiras AndreMiras merged commit 753bf73 into kivy:master Sep 10, 2023
9 checks passed
@tcaduser
Copy link
Contributor Author

Thanks so much for your help in getting this reviewed and accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants