Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ios deploy target #949

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Novfensec
Copy link

I just upgraded the latest supported IPHONEOS_DEPLOYMENT_TARGET to 17.0 as XCODE>=13.0 supports 12.0 to 17.5.5 latest.
Please consider this.

@Novfensec Novfensec marked this pull request as ready for review December 6, 2024 08:04
@AndreMiras
Copy link
Member

Hi @Novfensec thank you for looking this up. I'm out of the loop on iOS.
CI seems happy, but did you also test under this configuration yourself and confirm it builds/run OK?
Waiting for you feedback to merge

@Novfensec
Copy link
Author

Novfensec commented Dec 6, 2024

@AndreMiras
Github run:
https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12195143260

Earlier I got an error for version upgrade.

warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 12.0 to 17.5.99. 

When I upgraded , It passed that step sucessfully and now failing to build Images.xcassets

You can merge this as it resolves the issue with that version incompatibility.

@Novfensec
Copy link
Author

Novfensec commented Dec 7, 2024

Hey! @AndreMiras I got a successfull build at the Github run https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12210952062 with some little adjustments.

The workflow completed all steps without any failure compiling seamlessly. I'll open up a pull-request for those changes.

Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IPHONEOS_DEPLOYMENT_TARGET = 17.0; is too high, that will make every app incompatible on iOS devices running iOS < 17.0

I'm all-in for a DEPLOYMENT_TARGET increase, but we should consider setting it to an appropriate value (Better to check on kivy/kivy source code which APIs we require)

@Novfensec
Copy link
Author

Novfensec commented Jan 2, 2025

IPHONEOS_DEPLOYMENT_TARGET = 17.0; is too high, that will make every app incompatible on iOS devices running iOS < 17.0

I'm all-in for a DEPLOYMENT_TARGET increase, but we should consider setting it to an appropriate value (Better to check on kivy/kivy source code which APIs we require)

The we need to look dynamically for IPHONEOS_DEPLOYMENT_TARGET based on the supported versions by newer or older XCODE versions. By the latest IPHONEOS_DEPLOYMENT_TARGET = 12.0 is the lowest version supported by XCODE>=13.0.

@Novfensec
Copy link
Author

Novfensec commented Jan 6, 2025

@misl6 I found that

IPHONEOS_DEPLOYMENT_TARGET = 12.0 is in reach of older iPhone devices like;

  • iPhone 5s
  • iPhone 6 and 6 plus
  • iPhone SE (1st generation)

IPHONEOS_DEPLOYMENT_TARGET = 13.0: Adds dark mode, SwiftUI 1.0, and other modern features but drops support for iPhone 5s, 6, and 6 Plus.

IPHONEOS_DEPLOYMENT_TARGET = 14.0 Includes widgets and app clips but requires newer devices starting from iPhone 6s.

Now, your choice whichever you suggest I'll downgrade to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants