-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ios deploy target #949
base: master
Are you sure you want to change the base?
Conversation
Hi @Novfensec thank you for looking this up. I'm out of the loop on iOS. |
@AndreMiras Earlier I got an error for version upgrade. warning: The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target versions is 12.0 to 17.5.99. When I upgraded , It passed that step sucessfully and now failing to build Images.xcassets You can merge this as it resolves the issue with that version incompatibility. |
Hey! @AndreMiras I got a successfull build at the Github run https://github.com/Novfensec/Tic-Tac-Toe-Android/actions/runs/12210952062 with some little adjustments. The workflow completed all steps without any failure compiling seamlessly. I'll open up a pull-request for those changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPHONEOS_DEPLOYMENT_TARGET = 17.0;
is too high, that will make every app incompatible on iOS devices running iOS < 17.0
I'm all-in for a DEPLOYMENT_TARGET increase, but we should consider setting it to an appropriate value (Better to check on kivy/kivy
source code which APIs we require)
The we need to look dynamically for |
@misl6 I found that
Now, your choice whichever you suggest I'll downgrade to that. |
I just upgraded the latest supported
IPHONEOS_DEPLOYMENT_TARGET to 17.0
asXCODE>=13.0
supports12.0 to 17.5.5
latest.Please consider this.