Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigger buffer, allows large selection #655

Merged
merged 1 commit into from
Nov 30, 2021
Merged

Bigger buffer, allows large selection #655

merged 1 commit into from
Nov 30, 2021

Conversation

akshayaurora
Copy link
Member

Fixes Crash due to low buffer for selecting large number of files > 100
Ref: https://mail.python.org/pipermail/python-win32/2018-June/014071.html

@akshayaurora
Bigger buffer, allows large selection
d87c446 
Fixes Crash due to low buffer for selecting large number of files > 100
Ref: https://mail.python.org/pipermail/python-win32/2018-June/014071.html
AndreMiras
AndreMiras approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akshayaurora akshayaurora merged commit 7a71707 into master Nov 30, 2021
@akshayaurora akshayaurora deleted the Fix-LowBuffer-1 branch November 30, 2021 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

@matham matham Awaiting requested review from matham

@tshirtman tshirtman Awaiting requested review from tshirtman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akshayaurora @AndreMiras