Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear documentation for Processors #689

Merged
merged 10 commits into from
Jul 13, 2022
Merged

Clear documentation for Processors #689

merged 10 commits into from
Jul 13, 2022

Conversation

rshah713
Copy link
Contributor

@rshah713 rshah713 commented Jul 4, 2022

Updated README + docstring

@misl6
Copy link
Member

misl6 commented Jul 10, 2022 •
edited
Loading

Hi @rshah713 !

Seems that the Continuous Integration with Ubuntu / style test is failing, can you take care of the failures related to this PR?

misl6
misl6 requested changes Jul 10, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the Continuous Integration with Ubuntu / style test is failing, can you take care of the failures related to this PR?

@rshah713
Copy link
Contributor Author

Thanks for the comment @misl6! Most recent commits have all tests passing, feel free to merge

@rshah713 rshah713 requested a review from misl6 July 11, 2022 01:57
misl6
misl6 requested changes Jul 11, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Looks like we deprecated processors via #483.

plyer/platforms/linux/notification.py Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
plyer/facades/processors.py Show resolved Hide resolved
@rshah713
Copy link
Contributor Author

Just fixed the requested changes @misl6, let me know if there is anything else

@rshah713 rshah713 requested a review from misl6 July 11, 2022 20:40
misl6
misl6 approved these changes Jul 13, 2022
View reviewed changes
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM.

@misl6 misl6 merged commit 4075dc7 into kivy:master Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 misl6 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rshah713 @misl6