Choose a reasonable and valid number for the intent code #790
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Android file chooser
use a reasonable and valid number in the intent code.As this Stack Overflow post explains, the maximum value for the requestCode is
2^16
(65536
).Previously, the code used arbitrary numbers (
123456
and654321
), which is making some phones encounter a Java Exception:java.lang.IllegalArgumentException: Can only use lower 16 bits for requestCode
.