Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local recipes can not be patched any longer #1185

Closed
bobatsar opened this issue Nov 29, 2017 · 2 comments
Closed

Local recipes can not be patched any longer #1185

bobatsar opened this issue Nov 29, 2017 · 2 comments

Comments

@bobatsar
Copy link
Contributor

It seems since commit 9242bea local recipes which try to patch files can not run any longer. The call to get_recipe_dir() always returns a path in the ctx.root_dir and that is wrong for local recipes.

I tried to revert that commit here locally and now the patching works again.

@inclement
Copy link
Member

That's my mistake, sorry about that. I'll aim to push a fix soonish, although probably it's better to fix get_recipe_dir than to re-add the old behaviour.

@AndreMiras
Copy link
Member

AndreMiras commented May 18, 2018

Yes I'm also affected by this issue. What is you suggestion to fix get_recipe_dir() I'm willing to take a look because I'd like to submit my app to F-Droid.

Edit: #1276

inclement added a commit that referenced this issue May 19, 2018
…_recipes_patching

get_recipe_dir() also handle local recipes, fixes #1185
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants