-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uses target python3 on conditional buids, fixes #1485 #1515
Uses target python3 on conditional buids, fixes #1485 #1515
Conversation
`python3crystax` support was removed from the CI in kivy#1471. Conditional builds now relies on `python3` with fallback to `python2`. Adds `python3` support to `jedi` recipe to demonstrate.
Build is green on my fork https://travis-ci.org/AndreMiras/python-for-android/builds/466184240
For some reason the conditional build script marked it as |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know much about the CI setup of p4a, but just from looking over the code I can't see anything that is obviously nonsense or questionable
version = 'v0.9.0' | ||
url = 'https://github.com/davidhalter/jedi/archive/{version}.tar.gz' | ||
|
||
depends = [('python2', 'python3crystax')] | ||
depends = [('python2', 'python3crystax', 'python3')] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't really documented anywhere, but you can/should omit this from the dependencies in which case all python recipes will be added automatically.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know thanks!
python3crystax
support was removed from the CI in #1471.Conditional builds now relies on
python3
with fallback topython2
.Adds
python3
support tojedi
recipe to demonstrate.