Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses target python3 on conditional buids, fixes #1485 #1515

Conversation

AndreMiras
Copy link
Member

python3crystax support was removed from the CI in #1471.
Conditional builds now relies on python3 with fallback to python2.

Adds python3 support to jedi recipe to demonstrate.

`python3crystax` support was removed from the CI in kivy#1471.
Conditional builds now relies on `python3` with fallback to `python2`.

Adds `python3` support to `jedi` recipe to demonstrate.
@AndreMiras
Copy link
Member Author

Build is green on my fork https://travis-ci.org/AndreMiras/python-for-android/builds/466184240
Conditional build raw log: https://api.travis-ci.org/v3/job/466184245/log.txt
Relevant log extract:

...
[INFO]:    Found multiple valid dependency orders:
[INFO]:        ['hostpython2', 'python2', u'jedi']
[INFO]:        ['hostpython3crystax', 'python3crystax', u'jedi']
[INFO]:        ['hostpython3', 'python3', u'jedi']
[INFO]:    Using the first of these: ['hostpython2', 'python2', u'jedi']
[INFO]:    Trying to find a bootstrap that matches the given recipes.
...
[INFO]:    Found 4 acceptable bootstraps: ['webview', 'service_only', 'sdl2', 'pygame']
[INFO]:    Using the first of these: webview
[INFO]:    Found a single valid recipe set: ['hostpython2', 'python2', u'jedi']
[INFO]:    -> directory context testapps/
('recipes modified:', set([u'jedi']))
('recipes to build:', set([u'jedi']))
incompatible with python3
falling back to python2
('recipes to build (no broken):', set([u'jedi']))
('requirements:', u'jedi,python2')
...
           working: BUILD SUCCESSFUL in 41s                                                        �[0m
...
�[1m[INFO]�[0m:    # APK renamed to bdisttest_python2-1.1-debug.apk
...
Done. Your build exited with 0.

For some reason the conditional build script marked it as incompatible with python3 and fell back to python2, but that's something to investigate in a different task to be investigated once that one is merged.
For now on at least the build doesn't crash with a KeyError: 'CRYSTAX_NDK_HOME'.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about the CI setup of p4a, but just from looking over the code I can't see anything that is obviously nonsense or questionable

version = 'v0.9.0'
url = 'https://github.com/davidhalter/jedi/archive/{version}.tar.gz'

depends = [('python2', 'python3crystax')]
depends = [('python2', 'python3crystax', 'python3')]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't really documented anywhere, but you can/should omit this from the dependencies in which case all python recipes will be added automatically.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to know thanks!

@inclement inclement merged commit 8bf9651 into kivy:master Dec 12, 2018
@AndreMiras AndreMiras deleted the feature/ticket1485_conditional_build_via_python3 branch December 13, 2018 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants