Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add google repository at allprojects #1521

Merged
merged 1 commit into from
Dec 12, 2018
Merged

Conversation

wo01
Copy link
Contributor

@wo01 wo01 commented Dec 12, 2018

@ghost
Copy link

ghost commented Dec 12, 2018

@AndreMiras @inclement I just came to the same conclusion that this is apparently required now - the google repos should be the first point of download, jcenter only if it's not on there, and due to their recent mass deletion hiccup some libs may not come back to jcenter (what a google employee said in the issue tracker - they didn't really seem to fully know themselves yet). So this change makes a lot of sense. Can we get this tested & merged soon? I'm test-building it for my project right now

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this change, works fine for me - also from my research online on how to fix this, I happened to have come up with the exact same change before seeing this, so while I'm not a maven expert it looks like the right thing to do to me.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you simply share the upstream issue and error?

@ghost
Copy link

ghost commented Dec 12, 2018

Upstream issue is here: https://issuetracker.google.com/issues/120759347

The detailed build error message is here: #1520

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants