Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix APP_PLATFORM not properly passed in NDKRecipe #1572

Merged
merged 1 commit into from Jan 13, 2019
Merged

Fix APP_PLATFORM not properly passed in NDKRecipe #1572

merged 1 commit into from Jan 13, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jan 9, 2019

Fix APP_PLATFORM not properly passed in NDKRecipe. This is needed so certain NDKAPI/--minimum-api values won't lead to build errors with NDK based recipes, e.g. when using NDKAPI=21 with the current jpeg recipe

@ghost ghost changed the title [WIP] Fix APP_PLATFORM not properly passed in NDKRecipe Fix APP_PLATFORM not properly passed in NDKRecipe Jan 9, 2019
@ghost
Copy link
Author

ghost commented Jan 9, 2019

Ok tested & ready for merge! it doesn't actually fix jpeg for NDKAPI 21 (seems to be a fundamental issue with the android libjpeg-turbo fork) but it should fix others, and I verified that the APP_PLATFORM env var is set, and recognized by the make script without a warning that it would be some invalid or unknown platform

@ghost
Copy link
Author

ghost commented Jan 10, 2019

The additional pushes you see are just rebases to latest master. I used this during a couple of builds now without any issues 👍 (all python 3 though, no python 2 builds)

@inclement inclement merged commit ce0a651 into kivy:master Jan 13, 2019
@inclement
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant