Make bootstrap dynamic for travis conditional builds #1594

opacam · 2019-01-15T19:44:52Z

This should solve: #1588

AndreMiras · 2019-01-15T20:10:15Z

Thanks for it @opacam I like the approach and we can probably merge after some testing.
The approach I was thinking of was to play with git diff --name-only and compile on bootstrap changes. So for instance if a PR touches service_only we recompile using this bootstrap.
With your approach it feels more like if the recipe is compatible with webview bootstrap only then that's the one that will be picked up. Am I right?

opacam · 2019-01-15T20:23:50Z

Oh yes, uses the system that we use to resolve the dependencies and pick up one bootstrap (just the same as when building without specifying a bootstrap)

Caused because we try to compile the package with hostpython and we need to use target python or we will not have the right python headers Resolves: kivy#1575

AndreMiras · 2019-02-10T01:23:17Z

ci/constants.py

+BROKEN_RECIPES_PYTHON2 = set([
+])
+# to be created via https://github.com/kivy/python-for-android/issues/1514
+BROKEN_RECIPES_PYTHON3 = set([


This list is already defined here

python-for-android/ci/constants.py

Line 70 in 0563ef0

BROKEN_RECIPES_PYTHON3 = set([

why would we override?
I would keep that comment about #1514 however, good idea

AndreMiras · 2019-02-10T01:33:43Z

ci/rebuild_updated_recipes.py

+        bootstrap = get_bootstrap(recipes | {target_python.name})
+        if bootstrap:
+            break
+        else:


I understand you wanted to keep some meaningful logs to see the fallback in action, but we could greatly simplify the code if we drop that feature actually. Having the trying to get a bootstrap forcing target python above would be more than enough to guess when falling back. If we do so you can drop all the else block and the enumerate requirement

AndreMiras · 2019-02-10T01:36:20Z

ci/rebuild_updated_recipes.py

+                    target_python_priorities[n + 1].name))
+                continue
+    if not bootstrap:
+        logger.warning('we didn\'t find any valid combination of bootstrap and'


Minor: this is a good example where I would use double quotes in my string, just to avoid escaping inner single quotes

AndreMiras · 2019-02-10T01:36:58Z

ci/rebuild_updated_recipes.py

+        logger.warning('we didn\'t find any valid combination of bootstrap and'
+                       ' target python...rebuild updated recipes cancelled.'
+                       'The recipes we couldn\'t rebuild are:'
+                       '\n\t-{}'.format('\n\t-'.join(list(recipes))))


Minor: why would you need the list() here, can't you join directly?

AndreMiras

Thanks for pushing this further, I left some early comments.
Also I'm puzzled if we want to support both python2 and python2legacy in that conditional build thing.
I would be tempted to support if it doesn't cause too much trouble, but drop at least one if it starts annoying us

opacam · 2019-02-10T01:48:38Z

Thanks for the comments, tomorrow I will look into it..:sleeping:
🌑

opacam · 2019-02-10T11:38:11Z

ci/constants.py

    'sympy',
    'vlc',
 ])
+# to be created via https://github.com/kivy/python-for-android/issues/XXXX


I think that we should create an issue page for python2.
What do you think @AndreMiras ?

I don't know if it's worth the effort, but feel free if want

opacam · 2019-02-10T11:38:59Z

ci/constants.py


 class TargetPython(Enum):
    python2 = 0
    python3crystax = 1


Maybe we should remove python3crystax?

Yes feel free 👍

opacam · 2019-02-10T11:42:28Z

ci/rebuild_updated_recipes.py

+    target_python_priorities = [
+        TargetPython.python3,
+        TargetPython.python2,
+        TargetPython.python2legacy


python2legacy is unlikely to be used unless we modify some pygame dependant recipe, which will be removed soon, so...I'm not sure if we have to introduce this 🤔

Yes by default I would be lazy and drop

Yes, but we already have the work done in here, so maybe we should maintain this, at least until @inclement can finish his pygame removal work, then maybe we could start to remove all the python2legacy stuff. It's easy to remove this, I'm more concerned with other python2legacy code...but we will add some more code to remove...mmm...@inclement, what is your opinion on this?

Ok, after thinking about it, I took the lazy road 😁, removed python2legacy

opacam · 2019-02-10T11:55:56Z

Again @AndreMiras, so many thanks for your comments of last night, you were right with all of that, and I must say, a lot better 😄. I don't plan touch this pull request unless you request me, so feel free to modify wathever you consider necessary, no problem 😉 (ahhh...and I don't have any more un-pushed work related with this pr...so we shouln't have problems If you want to add some commit, I could pull your changes...so feel free to modify whatever you want)

Because we don't need that anymore

To make easier to track any issue we got with python3's recipe

inclement assigned AndreMiras Jan 30, 2019

opacam force-pushed the enhance-rebuild-recipes branch from e0dfdc3 to 0563ef0 Compare February 10, 2019 00:43

opacam changed the title ~~Make bootstrap dynamic for travis conditional builds~~ [WIP] Make bootstrap dynamic for travis conditional builds Feb 10, 2019

AndreMiras reviewed Feb 10, 2019

View reviewed changes

opacam force-pushed the enhance-rebuild-recipes branch from 0563ef0 to a46564d Compare February 10, 2019 11:34

opacam commented Feb 10, 2019

View reviewed changes

opacam added 3 commits February 12, 2019 09:54

Make bootstrap dynamic for rebuild_updated_recipes

8d4a837

Clean up constants.py (Remove python3crystax of TargetPython)

286bdc1

Because we don't need that anymore

Restore python3's comment

c6d8763

To make easier to track any issue we got with python3's recipe

opacam force-pushed the enhance-rebuild-recipes branch from a46564d to c6d8763 Compare February 12, 2019 09:04

opacam changed the title ~~[WIP] Make bootstrap dynamic for travis conditional builds~~ Make bootstrap dynamic for travis conditional builds Feb 12, 2019

inclement changed the base branch from master to develop June 6, 2019 20:41

inclement closed this in 185936e Jul 14, 2019

Make bootstrap dynamic for travis conditional builds #1594

Make bootstrap dynamic for travis conditional builds #1594

Uh oh!

Conversation

opacam commented Jan 15, 2019

Uh oh!

AndreMiras commented Jan 15, 2019

Uh oh!

opacam commented Jan 15, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AndreMiras left a comment

Choose a reason for hiding this comment

Uh oh!

opacam commented Feb 10, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

opacam commented Feb 10, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

opacam commented Jan 15, 2019 •

edited

Loading