Added option to support custom shared libraries with <uses-library> tag #1684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pax0r
force-pushed
the
master
branch
2 times, most recently
from
a9bc663 to
9409cf7
Compare
inclement
approved these changes
Feb 6, 2019
inclement
previously requested changes
Feb 6, 2019
AndreMiras
reviewed
Feb 8, 2019
Minor refactor of list defaults in build.py
|
@inclement you have some ongoing "requested changes" that I think got addressed. Do you mind doing a final check and merging? |
|
@pax0r since @inclement seems to be afk I think we can merge soon. Have you been using this change for a while without issues? Do you think it's OK for a merge now? |
|
@AndreMiras Yes, we build application using some 3rd party library and had no issues. After merge I'll also provide patch for buildozer with support for this option. |
AndreMiras
dismissed
inclement’s stale review
comments about using default=[] were addressed, now merging
|
Merged thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for:
https://developer.android.com/guide/topics/manifest/uses-library-element