Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compile error of recipe "android" for non-sdl bootstrap build #1715

Merged
merged 1 commit into from
Feb 18, 2019

Conversation

j-devel
Copy link
Contributor

@j-devel j-devel commented Feb 18, 2019

Building an apk with --bootstrap=webview breaks at pythonforandroid/recipes/android/src/setup.py as follows:

$ p4a apk --private ./myapp --package=org.example.myapp --name myapp --version 0.1 --bootstrap=webview --requirements=python2 --arch=armeabi-v7a --debug

(snip)

  RAN: /home/a/.local/share/python-for-android/build/other_builds/hostpython2/desktop/hostpython2/native-build/python setup.py build_ext -v

  STDOUT:
Traceback (most recent call last):
  File "setup.py", line 9, in <module>
    sdl_libs = lib_dict[os.environ['BOOTSTRAP']]
KeyError: 'webview'

This PR is to get around the KeyError that happens in any non-SDL bootstrap modes.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@AndreMiras AndreMiras merged commit 6ca419e into kivy:master Feb 18, 2019
@j-devel j-devel deleted the fix-android-setuppy-non-sdl branch February 18, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants