Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes psycopg2 lib install dir, closes #1711 #1723

Merged

Conversation

AndreMiras
Copy link
Member

Also note this recipe seems to depend on nl_langinfo which is only
available from ANDROID_API 26.

Also note this recipe seems to depend on `nl_langinfo` which is only
available from ANDROID_API 26.
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also hardcode a check for this, I guess, but still it's obviously an improvement. Thanks :)

@inclement inclement merged commit 593aa1e into kivy:master Feb 25, 2019
@AndreMiras
Copy link
Member Author

Yes you're right @inclement I actually was thinking of something like this, or eventually trying to make it possible to still run it even below 26 somehow.
Thanks for the review/merge

@AndreMiras AndreMiras deleted the feature/ticket1711_fix_psycopg2_compile branch February 25, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants