Updated sdl2_mixer version to 2.0.4 #1742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreMiras
reviewed
Mar 7, 2019
pythonforandroid/recipes/sdl2_mixer/toggle_modplug_mikmod_smpeg_ogg.patch
Show resolved
Hide resolved
ghost
reviewed
Mar 8, 2019
pythonforandroid/recipes/sdl2_mixer/toggle_modplug_mikmod_smpeg_ogg.patch
Outdated
Show resolved
Hide resolved
ghost
reviewed
Mar 8, 2019
pythonforandroid/recipes/sdl2_mixer/toggle_modplug_mikmod_smpeg_ogg.patch
Show resolved
Hide resolved
ghost
approved these changes
Apr 2, 2019
There was a problem hiding this comment.
Okay, we've discussed the changes to death and the original creator has tested it with their app, and right now I also tested that my app (which doesn't play sound but ships with SDL_mixer as all SDL2 bootstrap apps do by default) still builds & runs correctly. Unless someone else is still up for testing this, I suggest we just merge it
ghost
added
the
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates sdl2_mixer version to 2.0.4
Tested on a real-world app w/ python3