-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed build file for service_only bootstrap #1819
Conversation
Thanks for the contribution. This actually rings the bell, I think I saw a similar update in the past.
https://travis-ci.org/kivy/python-for-android/builds/534106361 |
Yes, it is part of an open PR (#1725) but I decided to create a separate PR since our software highly depends on the |
That's the one indeed, thanks for sharing. |
The build.py file expects the window arg to be set, however, when building with a service_only bootstrap, this variable is not set. This results in an error when building the private.mp3 resource.
9c43798
to
fcd4172
Compare
@AndreMiras done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Nice work, merged thanks! |
The build.py file expects the window arg to be set, however, when building with a service_only bootstrap, this variable is not set. This results in an error when building the private.mp3 resource.