Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build file for service_only bootstrap #1819

Merged
merged 1 commit into from
May 20, 2019

Conversation

devos50
Copy link
Contributor

@devos50 devos50 commented May 18, 2019

The build.py file expects the window arg to be set, however, when building with a service_only bootstrap, this variable is not set. This results in an error when building the private.mp3 resource.

@devos50 devos50 marked this pull request as ready for review May 18, 2019 07:16
@AndreMiras
Copy link
Member

Thanks for the contribution. This actually rings the bell, I think I saw a similar update in the past.
Anyway it looks good, but the build is failing for an unknown reason. I'd like us to investigate before merging. It's probably not related to this PR, but we now have errors all over the place like:

==================================== ERRORS ====================================
_____________________ ERROR collecting tests/test_graph.py _____________________
ImportError while importing test module '/home/travis/build/kivy/python-for-android/tests/test_graph.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_graph.py:1: in <module>
    from pythonforandroid.build import Context
E   ImportError: No module named pythonforandroid.build
____________________ ERROR collecting tests/test_logger.py _____________________
ImportError while importing test module '/home/travis/build/kivy/python-for-android/tests/test_logger.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_logger.py:3: in <module>
    from pythonforandroid import logger
E   ImportError: No module named pythonforandroid
______________ ERROR collecting tests/test_pythonpackage_basic.py ______________
ImportError while importing test module '/home/travis/build/kivy/python-for-android/tests/test_pythonpackage_basic.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_pythonpackage_basic.py:17: in <module>
    from pythonforandroid.pythonpackage import (
E   ImportError: No module named pythonforandroid.pythonpackage
____________________ ERROR collecting tests/test_recipe.py _____________________
ImportError while importing test module '/home/travis/build/kivy/python-for-android/tests/test_recipe.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
tests/test_recipe.py:5: in <module>
    from pythonforandroid.build import Context
E   ImportError: No module named pythonforandroid.build
________________ ERROR collecting tests/recipes/test_gevent.py _________________

https://travis-ci.org/kivy/python-for-android/builds/534106361

@devos50
Copy link
Contributor Author

devos50 commented May 18, 2019

This actually rings the bell, I think I saw a similar update in the past.

Yes, it is part of an open PR (#1725) but I decided to create a separate PR since our software highly depends on the service_only bootstrap 👍 .

@AndreMiras
Copy link
Member

That's the one indeed, thanks for sharing.
I'll try to take a look why the build is failing during the coming week so we can merge that PR

@AndreMiras
Copy link
Member

Hi @devos50 the issue was fixed by @opacam in #1820 could you rebase your pull request on master?

The build.py file expects the window arg to be set, however, when building with a service_only bootstrap, this variable is not set. This results in an error when building the private.mp3 resource.
@devos50 devos50 force-pushed the fix_build_service_only branch from 9c43798 to fcd4172 Compare May 19, 2019 10:18
@devos50
Copy link
Contributor Author

devos50 commented May 20, 2019

@AndreMiras done 👍

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AndreMiras AndreMiras merged commit 49e616c into kivy:master May 20, 2019
@AndreMiras
Copy link
Member

Nice work, merged thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants