-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix locating system python when it's not in $PATH (weird but happens, apparently) #1856
Conversation
For what it's worth, the problem was that travis uses a python that is not in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Jonast for the quick fix ❤️
👍 👏
It would be great that @AndreMiras or @inclement took a look on this and click the merge button if they are fine with this...
About the suggestions: feel free to apply that if you want but since that seems that you are the maintainer of this part of code, it's fine to me to keep that in your code style 😉
my style is ugly 😱 lol. I just tend to forget, always good to poke me about it |
Aaa...don't worry about the code style...I have a solution for that I will tell you my secret...I tend to use a little trick before commit/push anything...:laughing: There is a python module named I really recommend you that take a look on this project, I think that it's worth it 😉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
¡¡¡Good work @Jonast!!!
👍
Looks like travis failed because the last run predates the wheel fix, I've set it running again. |
Testing a fix for locating system python on travis.
This will most likely not work yet but I need to see the travis output to figure out what is wrong (it's a travis-specific problem) hence I'm already making the pull requestThis fixes the tests breaking when the system python is not in the$PATH
env var for some reason (usually that doesn't happen, but with travis &python3.7
for some reason it does)