Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various setup.py processing bugs #1862

Merged
merged 1 commit into from Jun 15, 2019
Merged

Fix various setup.py processing bugs #1862

merged 1 commit into from Jun 15, 2019

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2019

I made the setup.py processing unintentionally litter a file 😬 😬 (in the user project folder of all places) so that's not very good and here's the fix 😄 along with other fixes:

  • fix file litter of constraint.txt
  • fix --private relative paths during build.py's setup.py install
  • fix "" and "." not being recognized as folder by pythonpackage.py

Still WIP because I'm still testing it tested with various actual setup.py-based builds!

@ghost ghost added bug WIP labels Jun 11, 2019
- fix file litter of constraint.txt
- fix --private relative paths during build.py's setup.py install
- fix "" and "." not being recognized as folder by pythonpackage.py
@ghost ghost changed the title [WIP] Fix setup.py processing leaving over constraint.txt file in user project [WIP] Fix various setup.py processing bugs Jun 12, 2019
@ghost ghost changed the title [WIP] Fix various setup.py processing bugs Fix various setup.py processing bugs Jun 12, 2019
@ghost ghost removed the WIP label Jun 12, 2019
@ghost
Copy link
Author

ghost commented Jun 12, 2019

For what it's worth, the coverage thing: there is no new code except 2 conditionals that were plain missing, is this computed based on functions present? I did split up a big one (as once suggested by @AndreMiras !) simply because it got too nested to read well, but there isn't really any new code - and I actually added tests for the broken handling of pythonpackage of "" and ".", so in a way there's more tested than before 🤷‍♀️

Edit: I'm not objecting to having it tracked though, just slightly surprised at the way it's computed 😄

@ghost ghost requested a review from AndreMiras June 15, 2019 16:38
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I indeed like that you could split the code in a meaningful way with that run_setuppy_install() method. I feel like it makes things a bit more readable and surely more testable.
As for the coverage, well it only complains on a decrease by 0.02% which is nothing. It's probably simply because you added a couple of lines in a file that already had low coverage. Of course I hope nobody is going to block a PR because the coverage decreased by such a tiny amount 😄

@AndreMiras AndreMiras merged commit 85207a0 into kivy:develop Jun 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant