Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix foreground notification being mandatory and more (attempt 2) #1888

Merged
1 commit merged into from Jul 28, 2019
Merged

Fix foreground notification being mandatory and more (attempt 2) #1888

1 commit merged into from Jul 28, 2019

Commits on Jul 28, 2019

  1. Fix foreground notification being mandatory and more. Details: 

    - Adds start_service_not_as_foreground() to avoid always displaying
  an associated notification without this being configurable at runtime.
  It only is configurable right now if setting the foreground property
  via --service, which cannot be done when using the simpler
  service/main.py entrypoint

- Fixes service_only service code template not rendering .foreground
  correctly since it added an outdated, useless function name override

- Fixes notification channel name which is visible to end user
  hardcoding "python" in its name which is not ideal for end user
  naming (since the average user might not even know what python is)

- Fixes override of doStartForeground() leading to quite some
  error-prone code duplication
    Jonas Thiem committed Jul 28, 2019
    Configuration menu
    Copy the full SHA
    db6e735 View commit details
    Browse the repository at this point in the history