Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated numpy recipe to version 1.16.4 #1892

Merged
merged 3 commits into from
Jun 29, 2019
Merged

Updated numpy recipe to version 1.16.4 #1892

merged 3 commits into from
Jun 29, 2019

Conversation

inclement
Copy link
Member

@inclement inclement commented Jun 26, 2019 •
edited
Loading

This seems to fix the recipe, it works for me on both armeabi-v7a and arm64-v8a. Resolves #1873.

@inclement inclement added the WIP label Jun 26, 2019
@inclement inclement mentioned this pull request Jun 26, 2019
Closed
@inclement inclement removed the WIP label Jun 28, 2019
@inclement inclement force-pushed the update_numpy_1_16_4 branch 2 times, most recently from b47e220 to 00a59e7 Compare June 28, 2019 22:54
inclement added 2 commits June 29, 2019 00:03
@inclement
Updated numpy recipe to version 1.16.4
e4515df 
Undid unnecessary parts of 1.16.4 recipe change

Fully replaced numpy 1.15.1 patches with 1.16.4 patches

Removed git commit info from patches
@inclement
Updated numpy version targeted by matplotlib recipe
456b6a8
@inclement inclement force-pushed the update_numpy_1_16_4 branch from 00a59e7 to 456b6a8 Compare June 28, 2019 23:03
@inclement
Copy link
Member Author

This seems good to me now, commits tidied up and working fine for me.

@inclement inclement requested a review from AndreMiras June 28, 2019 23:04
@opacam
Copy link
Member

opacam commented Jun 29, 2019

🤔...why is failing the matplotlib recipe in CI?

...maybe numpy recipe has troubles in finding our compiled graphic libraries (freetype and png), see: https://travis-ci.org/kivy/python-for-android/jobs/551991431#L5947-L5958

I just made a build with the current numpy recipe and matplotlib to check and I got this for the same lines I pointed above:

[DEBUG]:   	REQUIRED DEPENDENCIES AND EXTENSIONS
[DEBUG]:   	                 numpy: yes [not found. pip may install it below.]
[DEBUG]:   	      install_requires: yes [handled by setuptools]
[DEBUG]:   	                libagg: yes [pkg-config information for 'libagg' could not
[DEBUG]:   	                        be found. Using local copy.]
[DEBUG]:   	              freetype: yes [version unknown]
[DEBUG]:   	                   png: yes [version 1.6.36]
[DEBUG]:   	                 qhull: yes [pkg-config information for 'libqhull' could not
[DEBUG]:   	                        be found. Using local copy.]

@inclement
Copy link
Member Author

There's a fair chance that the matplotlib recipe never passed the CI test, it's only coming up now because the changed recipes test catches it. It looks like the issues raised relate to the local environment where it isn't sufficiently separated from the matplotlib recipe build, I'll try to check this out in a VM.

@opacam
Copy link
Member

opacam commented Jun 29, 2019

Yeah, you are right, I just tested it, I made a silly change in matplotlib recipe with current develop branch, to force CI tests and it also fails with the same error message, so ...I think that we should add matplotlib to BROKEN_RECIPES_PYTHON3 in ci/constants.py with some message explaining this (we can do it later)

opacam
opacam previously approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks @inclement!!

@inclement
Copy link
Member Author

inclement commented Jun 29, 2019 •
edited
Loading

@opacam I updated the broken recipes in this PR, could you approve again if it looks good to you?

Edit: issue tracked in #1900

opacam
opacam approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@opacam opacam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

AndreMiras
AndreMiras approved these changes Jun 29, 2019
View reviewed changes
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, let's merge 🎊

AndreMiras
AndreMiras reviewed Jun 29, 2019
View reviewed changes
ci/constants.py
@@ -77,6 +78,7 @@ class TargetPython(Enum):
# mpmath package with a version >= 0.19 required
'sympy',
'vlc',
'matplotlib', # https://github.com/kivy/python-for-android/issues/1900
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping our CI green and thanks for tracking the issue 👏

@inclement inclement merged commit 06b5958 into kivy:develop Jun 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndreMiras AndreMiras AndreMiras approved these changes

@opacam opacam opacam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

numpy recipe bug arm64-v8a
3 participants
@inclement @opacam @AndreMiras