Fix run_pymodules_install when project_dir isn't supplied
#1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opacam
commented
Jun 28, 2019
| project_dir = abspath(project_dir) | ||
| # We change current working directory later, so this has to be an absolute | ||
| # path or `None` in case that we didn't supply the `project_dir` via kwargs | ||
| project_dir = abspath(project_dir) if project_dir else None |
There was a problem hiding this comment.
Since we set None as default kwarg value for project_dir in method run_pymodules_install, this line can make it crash the build if we call the mentioned method without providing the kwarg, so we must make sure that we call abspath without None or it will make fail the build
AndreMiras
approved these changes
Jun 28, 2019
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Jun 28, 2019
Regression test for the fix introduced in kivy#1898.
|
Here is the regression test #1899 |
AndreMiras
added a commit
to AndreMiras/python-for-android
that referenced
this pull request
Jun 29, 2019
Regression test for the fix introduced in kivy#1898.
inclement
added a commit
that referenced
this pull request
Jun 29, 2019
…ules_install_regression_test Simple run_pymodules_install test, refs #1898
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.