Added missing recommendations command and cleaned up code #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been the original value, agreed in kivy#1918
|
Also updated minimum python version supported to 3.6, as originally agreed in #1918 - it's my mistake that I left it at 3.4 in that PR. This minimum version is now essential since I added f-strings to the code. |
AndreMiras
reviewed
Sep 1, 2019
|
This one is also failing only on osx with the pyconfig.h error...not sure what's wrong, although it seems fairly clear this PR is not the culprit. |
|
Tests failing only due to macos issue also present on trunk. |
AndreMiras
approved these changes
Feb 16, 2020
|
Thanks! |
|
For records, this got fixed recently via #2063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added this missing command, which existed in the argument parser but wasn't actually implemented.
Not sure what format we really want, but just having the command available is probably an improvement for now.
I thought about removing the argument entirely, but it does seem useful to be able to print the p4a recommendations easily.