-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove superfluous recipes #1983
Conversation
Release 2019.07.08
Release 2019.08.09
Thank you @rnixx less is more, I love it! |
Seems that some of those recipes are tested. need to take a look |
Thank you to look into it 🍻 |
@AndreMiras I re-added pysdl2 and six recipes because they showed up somewhere in tests in the dependencies list. Now CI is sane again. I had no closer look at the test implementation itself, an isolated look right now not makes much sense to me with #1745 and #1625 in mind. Once i find some more time, I'm interested in taking a closer look into dependency resolving, there's some room for improvement. |
Awesome work @rnixx thanks a mil, PR that remove code are my favorite ones! |
Hi @rnixx I started taking a look, but I get compilation errors (libffi) and I'm not able to perform my runtime tests. I'm not really sure why since the CI is fine 🤔
That would also kick theses merge commits we have and keep the history clean. |
#1387