Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous recipes #1983

Closed
wants to merge 4 commits into from
Closed

Remove superfluous recipes #1983

wants to merge 4 commits into from

Conversation

rnixx
Copy link
Member

@rnixx rnixx commented Sep 15, 2019

@rnixx rnixx mentioned this pull request Sep 15, 2019
17 tasks
@AndreMiras
Copy link
Member

Thank you @rnixx less is more, I love it!
Do you know why quite some tests are failing? https://travis-ci.org/kivy/python-for-android/jobs/585146437

@rnixx
Copy link
Member Author

rnixx commented Sep 15, 2019

Seems that some of those recipes are tested. need to take a look

@AndreMiras
Copy link
Member

Thank you to look into it 🍻
Once you're done with it, basically we just need to double check all the recipe we killed still import OK at runtime on device. I will verify that once CI is happy.

@rnixx
Copy link
Member Author

rnixx commented Sep 15, 2019

@AndreMiras I re-added pysdl2 and six recipes because they showed up somewhere in tests in the dependencies list. Now CI is sane again. I had no closer look at the test implementation itself, an isolated look right now not makes much sense to me with #1745 and #1625 in mind. Once i find some more time, I'm interested in taking a closer look into dependency resolving, there's some room for improvement.

@AndreMiras
Copy link
Member

Awesome work @rnixx thanks a mil, PR that remove code are my favorite ones!
This is definitely next in my list to test, hopefully before Wednesday.

@AndreMiras AndreMiras self-assigned this Sep 15, 2019
@AndreMiras
Copy link
Member

Hi @rnixx I started taking a look, but I get compilation errors (libffi) and I'm not able to perform my runtime tests. I'm not really sure why since the CI is fine 🤔
Can you rebase that pull request on develop?

git rebase upstream/develop

That would also kick theses merge commits we have and keep the history clean.

AndreMiras pushed a commit to AndreMiras/python-for-android that referenced this pull request May 16, 2020
Merges/squash kivy#1983
with a rebasing on develop, closes kivy#1983
AndreMiras pushed a commit to AndreMiras/python-for-android that referenced this pull request May 16, 2020
Merges/squash kivy#1983
with a rebasing on develop, closes kivy#1983
AndreMiras pushed a commit to AndreMiras/python-for-android that referenced this pull request May 16, 2020
Merges/squash kivy#1983
with a rebasing on develop, closes kivy#1983
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants