Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes ffmpeg build on ndk 19 #1997

Merged
merged 6 commits into from
Nov 23, 2019
Merged

Conversation

misl6
Copy link
Member

@misl6 misl6 commented Oct 5, 2019

Targets issue #1996 .

  • ffmpeg builds
  • ffmpeg builds w/ openssl
  • ffmpeg builds w/ libx264
  • ffmpeg builds w/ libshine
  • disabled libshine due to the missing symbol error and added a comment for it

Known issues:

  • if libshine is enabled libavcodec is throwing an exception during runtime: ffpyplayer - ImportError: dlopen failed: cannot locate symbol "shine_set_config_mpeg_defaults" referenced by "/data/app/myapp==/lib/arm/libavcodec.so".. ( disabled libshine as a workaround)

Tested over a https/hls stream on both arm64-v8a and armeabi-v7a .

@misl6 misl6 changed the title [WIP] Fixes ffmpeg build on ndk 19 Fixes ffmpeg build on ndk 19 Nov 22, 2019
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for giving this recipe some love again.
Travis build failed most likely because it compiled for too long silently as describe by @opacam #2011 (comment) but I'm not yet sure I want to put such a verbose hack back if it's only few failing recipe.
For now I would only try to prefix the command with a travis_wait 20. Maybe @misl6 you could try that and even extend to the max of 30 minutes if it still fail.
It's in .travis.yml you can update this line:

script: make docker/run/make/rebuild_updated_recipes

to:

script: travis_wait 30 make docker/run/make/rebuild_updated_recipes

Hopefully it helps

@@ -4,7 +4,7 @@


class FFMpegRecipe(Recipe):
version = 'n3.4.5'
version = '007e03348dbd8d3de3eb09022d72c734a8608144'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about using a tag to a recent version instead of a commit?
https://github.com/FFmpeg/FFmpeg/releases

tito
tito previously approved these changes Nov 23, 2019
Copy link
Member

@tito tito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for me

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants