-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
twisted: updated to 19.7.0 + removed inceremental.path #2006
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it looks like the patch might be needed at least on Ubuntu somehow, see build error on CI:
https://travis-ci.org/kivy/python-for-android/jobs/600355532
distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('incremental>=16.10.1')
6e3c18b
to
e6e5252
Compare
indeed, I've restored the patch. |
Thanks!
|
Last version is building fine with p4a.
e6e5252
to
9666980
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for spending time ont it
Last version is building fine with p4a. Also incremental.patch doesn't
seem needed anymore (using Python 3), I could build without it.