Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

twisted: updated to 19.7.0 + removed inceremental.path #2006

Merged
merged 1 commit into from
Oct 21, 2019

Conversation

goffi-contrib
Copy link
Contributor

Last version is building fine with p4a. Also incremental.patch doesn't
seem needed anymore (using Python 3), I could build without it.

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, it looks like the patch might be needed at least on Ubuntu somehow, see build error on CI:
https://travis-ci.org/kivy/python-for-android/jobs/600355532

distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('incremental>=16.10.1')

@goffi-contrib
Copy link
Contributor Author

Thanks for the PR, it looks like the patch might be needed at least on Ubuntu somehow, see build error on CI:
https://travis-ci.org/kivy/python-for-android/jobs/600355532

distutils.errors.DistutilsError: Could not find suitable distribution for Requirement.parse('incremental>=16.10.1')

indeed, I've restored the patch.

@AndreMiras
Copy link
Member

Thanks!
Build is still failing because that patch probably needs an update now 😕

Hunk #1 FAILED at 227.	
1 out of 1 hunk FAILED -- saving rejects to file src/twisted/python/_setup.py.rej
[INFO]:    STDERR:
	
Traceback (most recent call last):
  File "setup_testapp_python3_sqlite_openssl.py", line 22, in <module>
    package_data={'testapp_sqlite_openssl': ['*.py', '*.png']}
  File "/usr/lib/python3.6/distutils/core.py", line 148, in setup
    dist.run_commands()
  File "/usr/lib/python3.6/distutils/dist.py", line 955, in run_commands
    self.run_command(cmd)
  File "/usr/lib/python3.6/distutils/dist.py", line 974, in run_command
    cmd_obj.run()
  File "/home/user/pythonforandroid/bdistapk.py", line 80, in run
    main()
  File "/home/user/pythonforandroid/entrypoints.py", line 18, in main
    ToolchainCL()
  File "/home/user/pythonforandroid/toolchain.py", line 671, in __init__
    getattr(self, args.subparser_name.replace('-', '_'))(args)
  File "/home/user/pythonforandroid/toolchain.py", line 155, in wrapper_func
    build_dist_from_args(ctx, dist, args)
  File "/home/user/pythonforandroid/toolchain.py", line 209, in build_dist_from_args
    args, "ignore_setup_py", False
  File "/home/user/pythonforandroid/build.py", line 573, in build_recipes
    recipe.apply_patches(arch)
  File "/home/user/pythonforandroid/recipe.py", line 550, in apply_patches
    arch.arch, build_dir=build_dir)
  File "/home/user/pythonforandroid/recipe.py", line 258, in apply_patch
    "-i", filename, _tail=10)
  File "/home/user/pythonforandroid/logger.py", line 180, in shprint
    for line in output:
  File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 863, in next
    self.wait()
  File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 792, in wait
    self.handle_command_exit_code(exit_code)
  File "/home/user/venv/lib/python3.6/site-packages/sh.py", line 815, in handle_command_exit_code
    raise exc
sh.ErrorReturnCode_1: 
  RAN: /usr/bin/patch -t -d /home/user/.local/share/python-for-android/build/other_builds/twisted-python3/armeabi-v7a__ndk_target_21/twisted -p1 -i /home/user/pythonforandroid/recipes/twisted/incremental.patch
  STDOUT:
patching file src/twisted/python/_setup.py
Hunk #1 FAILED at 227.
1 out of 1 hunk FAILED -- saving rejects to file src/twisted/python/_setup.py.rej

Last version is building fine with p4a.
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for spending time ont it

@AndreMiras AndreMiras merged commit 080ac01 into kivy:develop Oct 21, 2019
@goffi-contrib goffi-contrib deleted the twisted_19.7.0_update branch October 21, 2019 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants