Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method
vibrate(milliseconds)
was deprecated in API level 26,now we should use
vibrate(android.os.VibrationEffect)
.I labeled this
WIP
because I thing that we should consider the possibility to useplyer
instead of using the more low level way ofpyjnius
, because we are repeating the code a lot with all the testapps (except for the flask testapp...which uses the same solution but written slightly differently). But the vibration fix forplyer
it was merged recently, and we still not have a release with it, so it will force us to put a github requirement in our testapp setup.py files and pin it to a commit or master branch...so...@inclement and @AndreMiras, what do you think about this,
plyer
orpyjnius
?Note:
testapp_flask
and the standard onetestapp_sqlite_openssl
and this last one, you could also test it, without building it, via the corresponding job, you can download the testapps built with gh-actions via theArtificats
button 😄See also: https://developer.android.com/reference/android/os/Vibrator#vibrate(long)