Simplifies Dockerfile and fix GitHub runner space #2142
Conversation
|
It seems like the problem was seen 4 days ago on this repo and a similar fix helped out EmbarkStudios/wg-ui#53 |
Simplifies the Dockerfile as Python 2 was dropped. Renames to default "Dockerfile" so it's picked up by docker hub automatically. This is a follow-up for: kivy#2105 Adds the GitHub action build badge. Free up space before building the APKs to avoid the GitHub Action runner being full. The error was: ``` mkdir -p /home/user/.android/android-ndk-r19b \ && unzip -q android-ndk-r19b-linux-x86_64.zip -d /home/user/.android \ && ln -sfn /home/user/.android/android-ndk-r19b /home/user/.android/android-ndk \ && rm -f android-ndk-r19b-linux-x86_64.zip Error processing tar file(exit status 1): write /home/user/.android/android-ndk-r19b/toolchains/aarch64-linux-android-4.9/prebuilt/linux-x86_64/lib/bfd-plugins/LLVMgold.so: no space left on device Makefile:61: recipe for target 'docker/build' failed make: *** [docker/build] Error 1 ```` https://github.com/kivy/python-for-android/actions/runs/81658805 The "Free disk space" step could clear about ~10G and helped making the build pass. See output logs for details.
AndreMiras
force-pushed
the
feature/python2_drop_follow_up
branch
from
441a729 to
b5dfdaf
Compare
| python \ | ||
| python-pip \ |
There was a problem hiding this comment.
Oh boy, we still have some Python2 leftovers...nice that you remove that 😄
| # install cython for python 2 (for python 3 it's inside the venv) | ||
| RUN pip2 install --upgrade Cython==0.28.6 \ | ||
| && rm -rf ~/.cache/ | ||
|
|
There was a problem hiding this comment.
More removed Python2 leftovers 👍
| @@ -2,6 +2,7 @@ python-for-android | |||
| ================== | |||
|
|
|||
| [](https://travis-ci.org/kivy/python-for-android) | |||
| [](https://github.com/kivy/python-for-android/actions?query=workflow%3A%22Unit+tests+%26+build+apps%22) | |||
There was a problem hiding this comment.
Anxious to see how it will look like this badge 👍
There was a problem hiding this comment.
ahah, you could actually see it from my fork/branch https://github.com/AndreMiras/python-for-android/tree/feature/python2_drop_follow_up
But you will see soon enough as I'm merging, thanks for the review :)
|
Thanks for the quick review! I don't know if I could have sleep on a broken build 😄 |
|
I've also updated the Dockerfile path on the Docker Hub auto build to reflect the change |
Simplifies the Dockerfile as Python 2 was dropped.
Renames to default "Dockerfile" so it's picked up by docker hub automatically.
This is a follow-up for: #2105
Adds the GitHub action build badge.
Free up space before building the APKs to avoid the GitHub Action runner being full.
The error was:
https://github.com/kivy/python-for-android/actions/runs/81658805
The "Free disk space" step could clear about ~10G and helped making the build pass.
See output logs for details.