Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show loading screen while unpacking for webview bootstrap #2153

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Show loading screen while unpacking for webview bootstrap #2153

merged 2 commits into from
Apr 25, 2020

Conversation

kollivier
Copy link
Contributor

This is a port of the SDL bootstrap's UnpackTask fix to the webview bootstrap, so that the loading screen can be displayed during unpack instead of a plain black window.

@kollivier
Copy link
Contributor Author

Note that although it shows a lot of lines changed, a majority of the changes are just reformatting caused by moving the actual UI and python loading code into UnpackTask.onPostExecute. (And needing to access PythonActivity via PythonActivity.mActivity since this became UnpackTask when the code got moved.

inclement
inclement approved these changes Apr 25, 2020
View reviewed changes
Copy link
Member

@inclement inclement left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@inclement inclement merged commit 41b363c into kivy:develop Apr 25, 2020
@AndreMiras AndreMiras deleted the unpack_task branch April 26, 2020 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inclement inclement inclement approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kollivier @inclement