:rotating light: Fix linting for setup.py #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
opacam
commented
Apr 26, 2020
opacam
commented
- F401 'os' imported but unused
- E303 too many blank lines (3)
- E302 expected 2 blank lines, found 1
- E305 expected 2 blank lines after class or function definition, found 1
- E251 unexpected spaces around keyword / parameter equals
AndreMiras
previously approved these changes
Apr 26, 2020
There was a problem hiding this comment.
Thanks and how about adding it to the sources to be linted?
https://github.com/kivy/python-for-android/blob/6781179/tox.ini#L25
- F401 'os' imported but unused - E303 too many blank lines (3) - E302 expected 2 blank lines, found 1 - E305 expected 2 blank lines after class or function definition, found 1 - E251 unexpected spaces around keyword / parameter equals
|
Nice thought!! 👍 ¡¡Thanks!! |
opacam
force-pushed
the
hotfix-linting-setuppy
branch
from
ffdf9a8 to
919e676
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.