Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Adds missing requests sub dependencies #2221

Merged
merged 1 commit into from
Jun 2, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ testapps-with-numpy/%: virtualenv
$(eval $@_APP_ARCH := $(shell basename $*))
. $(ACTIVATE) && cd testapps/on_device_unit_tests/ && \
python setup.py apk --sdk-dir $(ANDROID_SDK_HOME) --ndk-dir $(ANDROID_NDK_HOME) \
--requirements libffi,sdl2,pyjnius,kivy,python3,openssl,requests,sqlite3,setuptools,numpy \
--requirements libffi,sdl2,pyjnius,kivy,python3,openssl,requests,urllib3,chardet,idna,sqlite3,setuptools,numpy \
--arch=$($@_APP_ARCH)

testapps/%: virtualenv
Expand Down
2 changes: 1 addition & 1 deletion doc/source/troubleshooting.rst
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ Remember to always clean the build before rebuilding (`p4a clean builds`, or wit

On Ubuntu and derivatives::

apt install openssl
apt install libssl-dev
p4a clean builds # or with: buildozer `buildozer android clean

On macOS::
Expand Down
6 changes: 4 additions & 2 deletions testapps/on_device_unit_tests/setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@
app requirements via the dictionary `options`. Here you have some examples
to build the supported app modes::

- kivy *basic*: `sqlite3,libffi,openssl,pyjnius,kivy,python3,requests`
- kivy *basic*: `sqlite3,libffi,openssl,pyjnius,kivy,python3,requests,
urllib3,chardet,idna`
- kivy *images/graphs*: `kivy,python3,numpy,matplotlib,Pillow`
- kivy *encryption*: `kivy,python3,cryptography,pycryptodome,scrypt,
m2crypto,pysha3`
Expand All @@ -39,7 +40,8 @@
'apk':
{
'requirements':
'sqlite3,libffi,openssl,pyjnius,kivy,python3,requests',
'sqlite3,libffi,openssl,pyjnius,kivy,python3,requests,urllib3,'
'chardet,idna',
'android-api': 27,
'ndk-api': 21,
'dist-name': 'bdist_unit_tests_app',
Expand Down