Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpython3.8m.so should not have m suffix #2278

Merged
merged 1 commit into from
Dec 28, 2020
Merged

libpython3.8m.so should not have m suffix #2278

merged 1 commit into from
Dec 28, 2020

Conversation

davidhewitt
Copy link
Contributor

Hi,

I'm helping a user to diagnose a downstream issue PyO3/pyo3#1077 when compiling a Rust application using p4a. In the linked issue is a lot of background and the OP also contains a link to a minimal example.

Their build with p4a targeting Python 3.8 was failing with link errors. Their workaround was to manually link to libpython3.8m.so.

However, I understood the m suffix was removed with Python 3.8 after pymalloc builds became ABI-compatible with the mainline: https://docs.python.org/3/whatsnew/3.8.html#build-and-c-api-changes

So I think that libpython3.8m.so is a non-standard name for libpython, and propose here the m suffix is dropped by p4a.

I am very new to the p4a codebase, so please give me a heads-up for any other sections of the code that should be adjusted for this and I'm happy to round off this PR.

@inclement
Copy link
Member

Thanks, and sorry for the delay getting back to you - it seems the p4a developers have been otherwise occupied recently. The basic change looks good to me, but I think it will also be necessary to update the reference to libpython3.8m in pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonUtil.java. That's the only other thing I can think of offhand though.

@davidhewitt
Copy link
Contributor Author

Thanks, I've fixed that and a few other places in the codebase which appeared relevant.

CI failures seem unrelated - download error is presumably spurious and the travis issue looks to be kivy/buildozer#1144

@davidhewitt
Copy link
Contributor Author

ping @inclement is there anything I can do to help see this merged?

Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks for looking into it, addressing inclement comments and squashing everything 💪
Yeah dev have been pretty busy lately so thanks for your efforts and patience

@AndreMiras AndreMiras merged commit cb760ae into kivy:develop Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants