libpython3.8m.so
should not have m
suffix
#2278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm helping a user to diagnose a downstream issue PyO3/pyo3#1077 when compiling a Rust application using p4a. In the linked issue is a lot of background and the OP also contains a link to a minimal example.
Their build with p4a targeting Python 3.8 was failing with link errors. Their workaround was to manually link to
libpython3.8m.so
.However, I understood the
m
suffix was removed with Python 3.8 after pymalloc builds became ABI-compatible with the mainline: https://docs.python.org/3/whatsnew/3.8.html#build-and-c-api-changesSo I think that
libpython3.8m.so
is a non-standard name for libpython, and propose here them
suffix is dropped by p4a.I am very new to the p4a codebase, so please give me a heads-up for any other sections of the code that should be adjusted for this and I'm happy to round off this PR.