Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow using lottie files for splashscreen (SDL2 bootstrap) #2296

Merged
merged 1 commit into from
Aug 12, 2020

Conversation

tshirtman
Copy link
Member

@tshirtman tshirtman commented Aug 12, 2020

  • add --presplash-lottie option to build command allowing to pass a
    json file
  • add lottie to build.gradle if necessary
  • use an xml layout file to define the view (added/removed appropriately
    by build.py)
  • rework PythonActivity to select appropriate view at startup

https://youtu.be/tYvRQA9m6Do

AndreMiras
AndreMiras previously approved these changes Aug 12, 2020
Copy link
Member

@AndreMiras AndreMiras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds awesome!
A bit busy lately to test it, but looks good to me

doc/source/buildoptions.rst Show resolved Hide resolved
- add `--presplash-lottie` option to `build` command allowing to pass a
  json file
- add lottie to build.gradle if necessary
- use an xml layout file to define the view (added/removed appropriately
  by build.py)
- rework PythonActivity to select appropriate view at startup
@tshirtman tshirtman force-pushed the lottie_splashscreen branch from ce5d2e3 to 8e7f23f Compare August 12, 2020 22:47
@tshirtman tshirtman merged commit 524d621 into develop Aug 12, 2020
@tshirtman tshirtman deleted the lottie_splashscreen branch August 12, 2020 22:48
vesellov pushed a commit to vesellov/python-for-android that referenced this pull request Feb 10, 2021
- add `--presplash-lottie` option to `build` command allowing to pass a
  json file
- add lottie to build.gradle if necessary
- use an xml layout file to define the view (added/removed appropriately
  by build.py)
- rework PythonActivity to select appropriate view at startup
germn pushed a commit to germn/python-for-android that referenced this pull request Mar 20, 2021
- add `--presplash-lottie` option to `build` command allowing to pass a
  json file
- add lottie to build.gradle if necessary
- use an xml layout file to define the view (added/removed appropriately
  by build.py)
- rework PythonActivity to select appropriate view at startup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants