-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoids build error for opencv and bumps version to 4.5.1 #2419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, it looks good to me.
Looks like this could solve kivy/buildozer#1144 right?
I've made a tiny comment if you don't mind updating before we merge
Edit: note that Travis is failing with error: Can not find Rust compiler
, but that was prior your PR
Yes kivy/buildozer#1144 gets the same error I did:
And the cmake arguments I don't know how I could have created this error: |
That should be fixed by #2422 (when it's merged). |
|
You used the default Dockerfile? I tested only with the "default" SDK/NDK versions. The following is what the Dockerfile installs (Source: android.mk):
Perhaps this is the problem? As for my environment: I build the Dockerfile from thescheff:develop added the following vars in the container:
And ran the build:
|
Allows build with docker container. Without this changes, I could not build opencv with p4a.