Move PythonActivityUtil.unpackData to PythonUtil.unpackData #2462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I haven't investigated why the tests are failing. |
|
looks like travis reached some limit, all other tests are sane now |
|
one question is whether we should remove PythonActivityUtil entirely since it's not used any more in bootstraps or keep for B/C in case someone depends on it in possible customizations. |
AndreMiras
reviewed
Jun 11, 2021
pythonforandroid/bootstraps/common/build/src/main/java/org/kivy/android/PythonActivityUtil.java
Outdated
Show resolved
Hide resolved
|
Removed PythonActivityUtil. Two tests on travis are failing with docker pull rate limit, so probably unrelated. All other tests are fine. |
AndreMiras
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates unpackData for use outside activity context.