-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added py3dns recipe #2590
Added py3dns recipe #2590
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start, added a couple of minor comments.
Too bad the lib is not maintained if it's still being used.
By the way have you tried proposing your patch upstream?
Also have you tried to ask validate_email to dump/replace the dependency since it's unmaintained?
class Py3DNSRecipe(PythonRecipe): | ||
site_packages_name = 'DNS' | ||
version = '3.2.1' | ||
url = 'https://github.com/Neizvestnyj/py3dns/archive/{version}.zip' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using the official launchpad download link instead?
https://launchpad.net/py3dns/trunk/3.2.1/+download/py3dns-3.2.1.tar.gz
url = 'https://github.com/Neizvestnyj/py3dns/archive/{version}.zip' | |
url = 'https://launchpad.net/py3dns/trunk/{version}/+download/py3dns-{version}.tar.gz' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, well, I didn't think about it. py3dns works fine and does not require any changes yet. It's just that there is such a bug on android. The last validate_email
release was in 2015 :)
- with open(resolv_path, 'r') as stream: | ||
- return ParseResolvConfFromIterable(stream) | ||
+ try: | ||
+ "parses the /etc/resolv.conf file and sets defaults for name servers" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter too much, but docstring could stay where it was instead of being in the try/except block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR and follow up adjustments.
Too bad for validate_email not being too maintained either.
But overall looks good to me.
Will merge after the CI is done
I found an error in the
py3dns
module for android. And since this library is not on github and it has not been updated for more than 3 years, I decided to copy the library to my repository and fix the bug by adding a patch. This is a fairly popular library, used as a dependency forvalidate_email
.