Fix webview testapp jnius usage #2597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current Flask throws an exception if a view function returns `None`: ``` python : TypeError: The view function for 'vibrate' did not return a valid response. The function either returned None or ended without a return statement. ``` Maybe that was different in the past, but instead a proper response can be returned. An empty 200 would be fine, but a 204 No Content response is used since it better represents what's happening.
When flask is run in threaded mode, it creates a new thread to handle each response. In that case, Java classes found with jnius will use the system class loader instead of the app class loader since the new thread has no stack frame back to the app. Normally you'd resolve the classes first, but the test app is explicitly trying to delay loading the classes until needed. That won't work from new native threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable flask threading so that jnius works using the webview bootstrap. See #2533 for more details.