Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing service_library bootstrap + .aar build. #2612

Merged
merged 12 commits into from
Jul 11, 2022
Merged

Conversation

mzakharo
Copy link
Contributor

@mzakharo mzakharo commented Jun 1, 2022

This CL contains fixes, building service_library bootstrap with aar target. Tested on Android 12. My primary goal was to create a way to use flutter with p4a.

Here is my tutorial on how to marry flutter with p4a:
https://github.com/mzakharo/flutter_with_python_android/blob/main/README.md

Maybe a tutorial like this could be made part of p4a documentation. Comments?

@mzakharo mzakharo changed the title Fixing service_only bootstrap + .aar build. Fixing service_library bootstrap + .aar build. Jun 1, 2022
@mzakharo
Copy link
Contributor Author

mzakharo commented Jun 2, 2022

It took a few tries, but the new test Unit test aar is now passing

misl6
misl6 previously approved these changes Jul 9, 2022
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mzakharo,
Thank you, and sorry for the late reply!

Left a couple of minor comments, let me know what do you think about it :)

Makefile Outdated Show resolved Hide resolved
pythonforandroid/toolchain.py Outdated Show resolved Hide resolved
Copy link
Member

@misl6 misl6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@misl6
Copy link
Member

misl6 commented Jul 11, 2022

Maybe a tutorial like this could be made part of p4a documentation. Comments?

Looks good. Maybe you can write a more generic example, as may also help non-flutter users?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants