Gradle: Run the clean task before anything else to make sure nothing is cached. #2705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
AndreMiras
previously approved these changes
Nov 19, 2022
pythonforandroid/toolchain.py
Outdated
Comment on lines
1112
to
1114
| # WARNING: We should make sure to clean the build directory before building. | ||
| # Looks like our private.tar is causing issues to gradle. | ||
| output = shprint(gradlew, "clean", gradle_task, _tail=20, |
There was a problem hiding this comment.
Nice findings and fix 💪
Do you think we should reference this pull request or initial bug report with a refs #2705 in the comment since you explained it all well?
There was a problem hiding this comment.
I was waiting to split the original issue, into multiple chunks (as actually contains multiple issues, and some of them are still being triaged) and then totally forgot to add a reference.
So, I guess that now that we have a PR to reference, I will reference the PR. 👍
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
…is "cached". (kivy#2705) * Gradle: Run the clean task before anything else to make sure nothing is cached. * Reference the PR for the future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Headache time 🤕⏱️!
As clearly described by @DexerBR in #2704 :
For a still unknown(likely a Gradle bug) reason, the produced
APKis bigger on non-first builds.After some analysis (unpacked the APK, checked and compared the content), I can say that only the size of the APK itself is different, not the content, as when it gets unzipped, the size of the unzipped content is the same between the first build and subsequent ones.
The files md5 hashes are the same, except for the
assets/private.tarfile (and its content), as I'm not building withSOURCE_DATE_EPOCHset, which means that compileall uses thetimestampas the invalidation mode, making the build non-reproducible.That's where the 💡 toggled on.
What's the size of my
assets/private.tar?17MBWhat's the APK size difference between the first and subsequent builds?
17MBOuch! 😓
For some reason, Gradle creates a bigger APK, which is able to contain all the assets and code + 2x
private.tar(the old one, and the new one), but then only packages into it the newer one.I will try to investigate it on Gradle (and Android Gradle Plugin) codebase, but meanwhile, cleaning the build folder (via
./gradlew clean *****) avoids any caching and ensures a clean build, every time, and doesn't seem to take any considerable amount of time.EDIT:
Found a discussion on Google Issue Tracker about something similar: https://issuetracker.google.com/issues/172762362