InputType.TYPE_TEXT_FLAG_MULTI_LINE forces InputType.TYPE_TEXT even if SDLActivity.keyboardInputType is NULL
#2716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f SDLActivity.keyboardInputType is NULL
AndreMiras
approved these changes
Dec 11, 2022
shyamnathp
pushed a commit
to shyamnathp/python-for-android
that referenced
this pull request
Feb 17, 2023
…f SDLActivity.keyboardInputType is NULL (kivy#2716)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately (and I'm creating a detailed report for us and the SDL team), suggestions from Android keyboards are still not completely usable. 😔
A logic, that mimics every possible scenario should be implemented on our side or on SDL's side if we decide to keep using input from SDL on mobile devices (which still makes sense ATM).
In one of the recents SDL updates,
InputType.TYPE_TEXT_FLAG_MULTI_LINEhas been or-ed with the InputType.That is preventing
InputType.TYPE_NULL(which is the default onkivy/kivy==master) to work, asInputType.TYPE_TEXT_FLAG_MULTI_LINEforcesInputType.TYPE_TEXTeven ifSDLActivity.keyboardInputTypeisInputType.TYPE_NULL.If needed
InputType.TYPE_TEXT_FLAG_MULTI_LINEshould be moved on our InputType selection logic inkivy/kivy.See: kivy/kivy#7744 for further details.